Fix spurious shadowing for higher-order implicits #2739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `x` had implicit function type, the previous algorithm did not realize that `x` and `x.apply(y)` were the same reference. Therefore, a spurious shadowing error occurred and the implicit search failed.
The previously failing test is ho-implicits.scala. Two more tests are for various other aspects of the implicit calculus work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
xhad implicit function type, the previous algorithm did notrealize that
xandx.apply(y)were the same reference. Therefore,a spurious shadowing error occurred and the implicit search failed.